Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added USAGE_DATA.md #247

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Conversation

sudhirverma
Copy link
Contributor

No description provided.

@sudhirverma sudhirverma requested a review from mohitsuman April 25, 2022 07:19
USAGE_DATA.md Outdated

### Usage Data

* when extension is activated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* when extension is activated
* When the extension is activated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

USAGE_DATA.md Outdated
### Usage Data

* when extension is activated
* when a command contributed by extension is executed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* when a command contributed by extension is executed
* When following command(s) contributed by extension is executed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

USAGE_DATA.md Outdated
* when a command contributed by extension is executed
* command's ID
* command's error message (in case of exception)
* command's specific data like knative, function version and to check which command user has used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* command's specific data like knative, function version and to check which command user has used.
* command's specific data like kn version, fn version and to check which command user has used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #247 (916335e) into main (4065abb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files          77       77           
  Lines        3127     3127           
  Branches      531      531           
=======================================
  Hits         2665     2665           
  Misses        462      462           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4065abb...916335e. Read the comment docs.

USAGE_DATA.md Outdated
* command's ID
* command's error message (in case of exception)
* command's specific data like knative, function version and to check which command user has used.
* when extension is deactivated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* when extension is deactivated
* When the extension is deactivated

USAGE_DATA.md Outdated
* command's error message (in case of exception)
* command's specific data like knative, function version and to check which command user has used.
* when extension is deactivated
* Command which send data to telemetry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Command which send data to telemetry.
* Following are the commands which send data to telemetry.

@sudhirverma sudhirverma requested a review from mohitsuman April 25, 2022 07:53
@sudhirverma sudhirverma merged commit c47a45d into redhat-developer:main Apr 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants