Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add remote deploy action to support on-cluster build (#281) #282

Merged
merged 11 commits into from
Oct 24, 2022

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Oct 6, 2022

Signed-off-by: Luca Stocchi lstocchi@redhat.com

Fix #281

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 74.69% // Head: 74.62% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e78d457) compared to base (b87e6ef).
Patch coverage: 73.89% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   74.69%   74.62%   -0.07%     
==========================================
  Files          89       90       +1     
  Lines        3730     3894     +164     
  Branches      634      681      +47     
==========================================
+ Hits         2786     2906     +120     
- Misses        944      988      +44     
Impacted Files Coverage Δ
src/functions/active-task-view/command-node.ts 10.34% <0.00%> (-1.91%) ⬇️
src/git/git.ts 78.20% <78.20%> (ø)
src/cli/func-api.ts 44.26% <82.60%> (+6.39%) ⬆️
...ions/function-command/build-and-deploy-function.ts 69.37% <87.14%> (+8.35%) ⬆️
src/extension.ts 58.27% <90.00%> (+2.11%) ⬆️
src/util/platform.ts 88.23% <0.00%> (-11.77%) ⬇️
src/cli/cmdCli.ts 42.16% <0.00%> (-3.62%) ⬇️
src/util/watch.ts 93.33% <0.00%> (-3.34%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lstocchi
Copy link
Contributor Author

lstocchi commented Oct 20, 2022

As said before I'm still working on the tests but you can start playing with it and see if you notice some misbehavior.
To setup your cluster you need to install knative/tekton and these extra tasks

REPO=https://raw.githubusercontent.com/openshift-knative/kn-plugin-func/serverless-1.25.0
oc apply -f ${REPO}/pipelines/resources/tekton/task/func-buildpacks/0.1/func-buildpacks.yaml
oc apply -f ${REPO}/pipelines/resources/tekton/task/func-s2i/0.1/func-s2i.yaml
oc apply -f https://gist.githubusercontent.com/jrangelramos/15cad16980957c19c621e37ec8094cb4/raw/a4007c4defffc35d1da743b5994e7eb372506a05/func-deploy.yaml
oc apply -f https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.7/git-clone.yaml

Copy link
Collaborator

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's resolve the conflict and merge.

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@mohitsuman mohitsuman merged commit 9b3d07f into redhat-developer:main Oct 24, 2022
@lstocchi lstocchi deleted the i281 branch October 24, 2022 12:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend deploy action to support on-cluster build
3 participants