-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update func cli version #309
Conversation
Codecov ReportBase: 74.63% // Head: 74.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 74.63% 74.63%
=======================================
Files 89 89
Lines 3737 3737
Branches 638 638
=======================================
Hits 2789 2789
Misses 948 948 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of this new cli version comes with a new func.yaml structure. Are you sure it does not break anything? E.g the namespace field changes location.
Before it was
name: 'func'
namespace: 'blabla'
now
name: 'func'
deploy:
namespace: 'blabla'
There are two things to verify. First that everything works with the new structure. Second that if i open up a func with the old structure i can still perform any action so the func.yaml gets updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.