Publish to OpenVSX.

[rgrunber]

• Fixes Publish the vscode-knative extension to Open VSX #328

I'll need to test this out a bit more thoroughly, but this should be the right approach.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (485487b) 74.34% compared to head (233ce06) 74.34%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   74.34%   74.34%           
=======================================
  Files          90       90           
  Lines        3909     3909           
  Branches      689      689           
=======================================
  Hits         2906     2906           
  Misses       1003     1003           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rgrunber]

@lstocchi , in https://github.com/redhat-developer/vscode-knative/pull/322/files#diff-f6401d0dbc035410143f1adff95d0ae3a13fcb708414bd382f21bd54e5eabfb0 you removed some findNotifications calls relating to Downloading ${tool}. I needed to do the same for https://github.com/redhat-developer/vscode-knative/pull/329/files#diff-f6401d0dbc035410143f1adff95d0ae3a13fcb708414bd382f21bd54e5eabfb0R114 . It looks like findNotifications isn't able to detect the notification. Were you able to find the exact reason ?

Update: It looks like

vscode-knative/test/ui-test/common/testUtils.ts

Line 32 in 485487b

await center.getDriver().sleep(1000);

is the culprit. Commenting out that line restores it again. I guess it makes sense given that the downloads didn't look to take longer than ~1s when running the UI tests.

[lstocchi]

@lstocchi , in https://github.com/redhat-developer/vscode-knative/pull/322/files#diff-f6401d0dbc035410143f1adff95d0ae3a13fcb708414bd382f21bd54e5eabfb0 you removed some findNotifications calls relating to Downloading ${tool}. I needed to do the same for https://github.com/redhat-developer/vscode-knative/pull/329/files#diff-f6401d0dbc035410143f1adff95d0ae3a13fcb708414bd382f21bd54e5eabfb0R114 . It looks like findNotifications isn't able to detect the notification. Were you able to find the exact reason ?

Update: It looks like

vscode-knative/test/ui-test/common/testUtils.ts

Line 32 in 485487b

await center.getDriver().sleep(1000);

is the culprit. Commenting out that line restores it again. I guess it makes sense given that the downloads didn't look to take longer than ~1s when running the UI tests.

Hey Roland, sorry for the late response. Quite busy and i forgot to reply. AFAIK the ui tests in vscode knative have always been unstable. I know that Sudhir fought a bit on them before leaving. In that PR commenting that line did the magic but, if i recall correctly, the tests started failing again later. So to answer your question, no i didn't find the exact reason 😞

[rgrunber]

Hey Roland, sorry for the late response. Quite busy and i forgot to reply. AFAIK the ui tests in vscode knative have always been unstable. I know that Sudhir fought a bit on them before leaving. In that PR commenting that line did the magic but, if i recall correctly, the tests started failing again later. So to answer your question, no i didn't find the exact reason disappointed

Thanks for the info. I guess commenting out the findNotifications line isn't so bad because ultimately we confirm in the line below it with safeNotification that it does exist. The only difference I saw between the 2 was that the latter doesn't have a 1s delay before checking notifications, and the downloads to happen quickly.

@mohitsuman , let me know if you can review . This should add ensure we publish to OpenVSX in the next release.

[mohitsuman]

LGTM