Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added GH actions for vscode-knative release #350

Merged
merged 12 commits into from
Mar 18, 2024
Merged

Added GH actions for vscode-knative release #350

merged 12 commits into from
Mar 18, 2024

Conversation

msivasubramaniaan
Copy link
Contributor

Fixes: #349

@msivasubramaniaan
release GH action added
f5346fe 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
upstream vscode 1.64.0 and added update-readme
cf6628c 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Mar 12, 2024
rgrunber
rgrunber requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some larger changes to make (in review comments), but it should simplify this a lot.

@msivasubramaniaan
review comments were addressed
899c86a 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
added run ui test
a428f1b 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
upstream vscode-extension-tester
e0ee6b2 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
removed unwanted file
a1e8e73 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
rgrunber
rgrunber requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better.

I noticed a failure in the UI tests on one occasion, but the second run, it all passed. I can confirm whether they're pretty consistent. Worst case we just exclude them from the release workflow, which is fine as long as they run on every pr/commit.

@msivasubramaniaan
review comments were addressed
cf32542 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
upstream mocha v10.3.0 and updated release.yml
7fbdb97 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
rgrunber
rgrunber reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments.

@msivasubramaniaan
updated release yaml
00ed8e7 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
updated release yaml
0257666 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
updated release yaml
9702cc4 
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@rgrunber
Move continue-on-error outside of 'with'
a5abeb5 
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber merged commit 175be75 into redhat-developer:main Mar 18, 2024
3 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 349-add-gh-actions-for-release branch March 18, 2024 14:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rgrunber rgrunber Awaiting requested review from rgrunber

Assignees

@msivasubramaniaan msivasubramaniaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GH actions for release
2 participants
@msivasubramaniaan @rgrunber