Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Open In Browser for tagged revisions #58

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Jun 4, 2020

This adds a new context type of revision.tagged. Adds the Open In Browser command to this context type. This feature allows us to open directly any tagged version of the service.

This adds a new context type of `revision.tagged`. Adds the
Open In Browser command to this context type.  This
feature allows us to open directly any tagged version of the
service.
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   49.13%   49.02%   -0.12%     
==========================================
  Files          23       23              
  Lines         753      767      +14     
  Branches       97      102       +5     
==========================================
+ Hits          370      376       +6     
- Misses        383      391       +8     
Impacted Files Coverage Δ
src/tree/knativeTreeItem.ts 52.30% <0.00%> (-0.82%) ⬇️
src/extension.ts 37.93% <10.00%> (-7.07%) ⬇️
src/kn/config.ts 92.30% <100.00%> (+0.64%) ⬆️
src/tree/serviceDataProvider.ts 50.47% <100.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3ca92...4ee97b1. Read the comment docs.

Adds a test for checking the tag and percentage for a traffic
on a revision
@joshuawilson joshuawilson merged commit ea5821e into redhat-developer:master Jun 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants