Bugfix/cache unittest #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4f8a989d50a24731aada3e1a4668520946fe6969
Change-Id: Iee7a264b41c8cd23c88c3d77e4abc9a059a43314
fix one test that failed to release the lock - this blocked the follow on tests
|
@imcleod can you please close this? |
|
Closing at Steve's request as this is no longer needed. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: #3
When run in the unit test harness the MockStackEnvironment entry in sys.modules has a slightly different key. After changing that, and fixing the first test such that it releases the lock, all seems to be well.