Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for BRPOPLPUSH #251

Closed
Tracked by #231
chayim opened this issue Feb 14, 2024 · 0 comments
Closed
Tracked by #231

Add support for BRPOPLPUSH #251

chayim opened this issue Feb 14, 2024 · 0 comments
Assignees
@gerzse

Comments

@chayim
Copy link
Contributor

chayim commented Feb 14, 2024

Thanks for reporting an issue in NRedisStack! Please update the appropriate text below, as much data as possible really helps!

NRedisStack Version: What version of the library are you using

Redis Stack Version: What is the version of redis stack where this issue happens?

Description: Description of the issue, ideally with sample code, and a stack trace.
@chayim chayim mentioned this issue Feb 14, 2024
Closed
10 tasks
gerzse added a commit to gerzse/NRedisStack that referenced this issue Feb 15, 2024
@gerzse
Add support for the BLMOVE and BRPOPLPUSH commands
c6ccaf0 
Issues redis#235 and redis#251
@gerzse gerzse self-assigned this Feb 15, 2024
shacharPash added a commit that referenced this issue Feb 22, 2024
@gerzse @shacharPash
Add more blocking commands (#253)
db17b89 
* Rename existing blocking commands

The current naming for the blocking commands does not feel right. For
example "BzmPop", it feels like there are no naming rules. So rename
existing methods by this rule: Use capital letters at the beginning of
human-readable words, e.g. "Pop", and also use capital letters where the
Redis command has a single letter, e.g. "B", which stands for
"Blocking", "Z" which stands for "Set" and "M" which stands for "Multi".
So the new name is "BZMPop".

It's still a good time to do such renaming, because these commands have
not been released. Also it is a crucial moment to get the naming as
right as possible, for the same reason.

* Add ToString to RedisValueWithScore

* Add support for BLPOP and BRPOP commands

Issues #249 and #250

* Add support for the BLMPOP command

Issue #248

* Add support for the BLMOVE and BRPOPLPUSH commands

Issues #235 and #251

* Try to fix flaky test

* Use Redis fixture in CoreTests

* Remove ToString, not really needed

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Co-authored-by: shacharPash <93581407+shacharPash@users.noreply.github.com>
@gerzse gerzse closed this as completed Feb 23, 2024
gerzse added a commit to gerzse/NRedisStack that referenced this issue Feb 26, 2024
@gerzse
Async blocking commands
97af530 
Issues redis#232, redis#233, redis#234, redis#235, redis#237, redis#248, redis#249, redis#250, redis#251, redis#255

Add the async versions for the blocking commands: BZPOPMIN, BZPOPMAX,
BZMPOP, BLMOVE, BLMPOP, BLPOP, BRPOP, BRPOPLPUSH, XREAD and XREADGROUP.
@gerzse gerzse mentioned this issue Feb 26, 2024
Merged
shacharPash added a commit that referenced this issue Mar 6, 2024
@gerzse @shacharPash
Async blocking commands (#257)
29b4c61 
* Add support for blocking XREAD and XREADGROUP

Issues #237 and #255.

* Extend unit test coverage

* Async blocking commands

Issues #232, #233, #234, #235, #237, #248, #249, #250, #251, #255

Add the async versions for the blocking commands: BZPOPMIN, BZPOPMAX,
BZMPOP, BLMOVE, BLMPOP, BLPOP, BRPOP, BRPOPLPUSH, XREAD and XREADGROUP.

---------

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Co-authored-by: shacharPash <93581407+shacharPash@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@gerzse gerzse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chayim @gerzse