Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change TimeStamp from DateTime to Millisecond Instead of Ticks #127

Merged
merged 4 commits into from
May 8, 2023

Conversation

shacharPash
Copy link
Contributor

Closes #126

@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 14:47 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 14:47 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 14:47 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 14:47 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 15:02 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 15:02 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 15:02 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 15:02 — with GitHub Actions Inactive
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Co-authored-by: Steve Lorello <42971704+slorello89@users.noreply.github.com>
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 23:37 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 23:37 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 23:37 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 4, 2023 23:37 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 7, 2023 13:45 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 7, 2023 13:45 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 7, 2023 13:45 — with GitHub Actions Inactive
@shacharPash shacharPash temporarily deployed to REDIS_USER May 7, 2023 13:45 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (6f1290d) 93.27% compared to head (832c15f) 93.25%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   93.27%   93.25%   -0.03%     
==========================================
  Files          77       77              
  Lines        4582     4582              
  Branches      424      424              
==========================================
- Hits         4274     4273       -1     
- Misses        186      187       +1     
  Partials      122      122              
Impacted Files Coverage Δ
src/NRedisStack/TimeSeries/DataTypes/TimeStamp.cs 84.21% <100.00%> (-5.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from slorello89 May 8, 2023 07:18
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash added the bug Something isn't working label May 8, 2023
@shacharPash shacharPash merged commit 09dfce7 into master May 8, 2023
@shacharPash shacharPash deleted the Issue126/TimeStampTicks branch May 8, 2023 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeStamp from DateTime not working
3 participants