Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Supporting setting a default DIALECT for search commands #147

Merged
merged 16 commits into from
Jun 14, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jun 5, 2023

Closes #146
Now the user can set default dialect when creating the Search commands instance, or with SetDefaultDialect(int? defaultDialect).

Examples of setting DIALECT 2 as a default dialect:

ConnectionMultiplexer redis = ConnectionMultiplexer.Connect("localhost");
IDatabase db = redis.GetDatabase();

// Option 1:
var ft = db.FT(2);

// Option 2:
var ft = db.FT();
ft.SetDefaultDialect(2)

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch coverage: 97.18% and project coverage change: +0.32 🎉

Comparison is base (2dcac07) 93.25% compared to head (a1fe79b) 93.58%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   93.25%   93.58%   +0.32%     
==========================================
  Files          78       78              
  Lines        4625     4769     +144     
  Branches      426      448      +22     
==========================================
+ Hits         4313     4463     +150     
+ Misses        189      177      -12     
- Partials      123      129       +6     
Impacted Files Coverage Δ
src/NRedisStack/Search/SearchCommandsAsync.cs 92.85% <81.25%> (+1.39%) ⬆️
src/NRedisStack/Search/SearchCommands.cs 98.11% <92.00%> (+1.77%) ⬆️
src/NRedisStack/Search/AggregationRequest.cs 99.57% <99.36%> (+1.10%) ⬆️
src/NRedisStack/ModulePrefixes.cs 100.00% <100.00%> (ø)
src/NRedisStack/Search/Query.cs 98.15% <100.00%> (-0.26%) ⬇️
src/NRedisStack/Search/SearchCommandBuilder.cs 89.09% <100.00%> (+4.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash marked this pull request as ready for review June 7, 2023 10:45
@shacharPash shacharPash requested review from chayim and uglide June 7, 2023 10:46
@shacharPash shacharPash changed the title Change the Structure of AggregationRequest Ability to set default DIALECT for search commands Jun 13, 2023
@shacharPash shacharPash requested a review from chayim June 14, 2023 09:48
@chayim chayim changed the title Ability to set default DIALECT for search commands Supporting setting a default DIALECT for search commands Jun 14, 2023
@shacharPash shacharPash merged commit 69d7896 into master Jun 14, 2023
@shacharPash shacharPash deleted the Issue146/SearchDialect branch June 14, 2023 12:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RediSearch Dialect Version Configuration Option
3 participants