Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lint checks in CI runs #183

Merged
merged 58 commits into from
Sep 27, 2023
Merged

Lint checks in CI runs #183

merged 58 commits into from
Sep 27, 2023

Conversation

shacharPash
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ac897cc) 94.07% compared to head (60510b9) 94.06%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   94.07%   94.06%   -0.01%     
==========================================
  Files          82       82              
  Lines        5116     5109       -7     
  Branches      483      483              
==========================================
- Hits         4813     4806       -7     
  Misses        176      176              
  Partials      127      127              
Files Coverage Δ
src/NRedisStack/Gears/GearsCommandBuilder.cs 98.14% <100.00%> (ø)
src/NRedisStack/Gears/GearsCommands.cs 100.00% <100.00%> (ø)
src/NRedisStack/Gears/GearsCommandsAsync.cs 100.00% <100.00%> (ø)
src/NRedisStack/Graph/DataTypes/Edge.cs 97.22% <100.00%> (ø)
src/NRedisStack/Graph/DataTypes/Node.cs 100.00% <100.00%> (ø)
src/NRedisStack/Graph/DataTypes/Path.cs 94.73% <100.00%> (ø)
src/NRedisStack/Graph/GraphCache.cs 100.00% <100.00%> (ø)
src/NRedisStack/Graph/GraphCacheList.cs 97.36% <ø> (ø)
src/NRedisStack/Graph/GraphCommands.cs 94.44% <ø> (ø)
src/NRedisStack/Graph/GraphCommandsAsync.cs 94.44% <ø> (ø)
... and 40 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash shacharPash marked this pull request as ready for review September 11, 2023 07:14
@shacharPash shacharPash changed the title Format & Cleaning Format Code with dotnet format Sep 11, 2023
@chayim
Copy link
Contributor

chayim commented Sep 13, 2023

@shacharPash WDYT about having CI check this as a linter job? Not actually changing, but failing if not applied? This would bring it inline with other clients. For example: redis-py or go

@chayim chayim changed the title Format Code with dotnet format Lint checks in CI runs Sep 27, 2023
@shacharPash shacharPash merged commit 3d639ce into master Sep 27, 2023
@shacharPash shacharPash deleted the Cleaning2 branch September 27, 2023 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants