Add support for BZMPOP, BZPOPMIN and BZPOPMAX #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 94.16% 94.12% -0.04%
==========================================
Files 85 87 +2
Lines 5178 5279 +101
Branches 487 496 +9
==========================================
+ Hits 4876 4969 +93
- Misses 178 183 +5
- Partials 124 127 +3 ☔ View full report in Codecov by Sentry. |
gerzse
force-pushed
the
add-support-for-bzmpop
branch
3 times, most recently
from
d075e7c to
579d1d8
Compare
gerzse
force-pushed
the
add-support-for-bzmpop
branch
4 times, most recently
from
c7ae0f5 to
51b5feb
Compare
Fix some typos in the markdown files and run `dotnet format` on existing code.
Change the settings so that documentation is included in the build.
gerzse
force-pushed
the
add-support-for-bzmpop
branch
4 times, most recently
from
4aafc50 to
5870af6
Compare
gerzse
changed the title
gerzse
force-pushed
the
add-support-for-bzmpop
branch
from
5870af6 to
410c474
Compare
Add support for the BZMPOP, BZPOPMIN, BZPOPMAX commands. Issues redis#232, redis#233 and redis#234. These commands are blocking on the server, so they go against the current policy of the StackExchange.Redis library. Therefore make it obvious in the code documentation that attention must be given to the timeout in the connection multiplexer, client-side. The StackExchange.Redis library already defines a type for the payload returned by BZMPOP (which is the same as for ZMPOP), namely the SortedSetPopResult class. However, the constructor of that class is internal in the library, so we can't create instances of it. Therefore roll our out type for a <value, score> pair, and use Tuple to pair a key with a list of such <value, score> pairs. Instead of using Order to signal from which end of the sorted set to pop, define a MinMaxModifier enum, which more clearly expresses the intention and maps directly to the Redis command being executed.
gerzse
force-pushed
the
add-support-for-bzmpop
branch
from
410c474 to
8948d82
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the BZMPOP, BZPOPMIN, BZPOPMAX commands.
Issues #232, #233 and #234.