Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for blocking XREAD and XREADGROUP #256

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Feb 26, 2024

Add support for XREAD and XREADGROUP

Issues #237 and #255.

@gerzse gerzse requested a review from shacharPash February 26, 2024 10:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 99.15966% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.38%. Comparing base (2ec5430) to head (ae2916a).

Files Patch % Lines
...Stack/CoreCommands/DataTypes/RedisStreamEntries.cs 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   94.27%   94.38%   +0.10%     
==========================================
  Files          87       88       +1     
  Lines        5367     5486     +119     
  Branches      503      518      +15     
==========================================
+ Hits         5060     5178     +118     
- Misses        181      182       +1     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thing this PR was included in #257

Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thing this changes were included in PR #257

@shacharPash shacharPash merged commit 5f8b0b0 into redis:master Mar 6, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants