-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pipeline support #50
Pipeline support #50
Conversation
Codecov ReportBase: 93.22% // Head: 93.32% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 93.22% 93.32% +0.09%
==========================================
Files 66 76 +10
Lines 4460 4555 +95
Branches 420 422 +2
==========================================
+ Hits 4158 4251 +93
- Misses 180 181 +1
- Partials 122 123 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is a temporary solution to support pipelines, var pipeline = new Pipeline(db);
pipeline.Json().Set(...);
pipeline.Json().Get(...); Without pipeline.AddCommand(JsonCommandBuilder.Set(...)); |
@shacharPash did you see the conflict? |
I fixed it now 👍 |
pipeline.Db.ExecuteAsync("FLUSHALL"); | ||
|
||
string jsonPerson = JsonSerializer.Serialize(new Person { Name = "Shachar", Age = 23 }); | ||
var setResponse = pipeline.Json.SetAsync("key", "$", jsonPerson); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
Hi @shacharPash, working on pipeline examples and found that ModulePrefix has not been added for some of the module commands except public class Pipeline
{
public Pipeline(IConnectionMultiplexer muxer)
{
_batch = muxer.GetDatabase().CreateBatch();
}
private IBatch _batch;
public void Execute()
{
_batch.Execute();
}
public IJsonCommandsAsync Json => new JsonCommandsAsync(_batch); // Json
public ISearchCommandsAsync Search => new SearchCommandsAsync(_batch); //search
public IDatabaseAsync Db => _batch;
} |
Hi @Jeevananthan-23, The reason I haven't added them until now is because I haven't yet added pipeline tests to each of the modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge, if CI passes
No description provided.