Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix code examples in README #86

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Fix code examples in README #86

merged 4 commits into from
Mar 1, 2023

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Mar 1, 2023

  • Specify all required dependencies
  • Add missing db initialization line
  • Use anonymous type to make JSON example runnable

- Specify all required dependencies
- Add missing db initialization line
- Use anonymous type to make JSON example runnable
@uglide uglide requested review from shacharPash and chayim March 1, 2023 10:27
Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (19a3f1f) 93.36% compared to head (09b4774) 93.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          77       77           
  Lines        4566     4566           
  Branches      422      422           
=======================================
  Hits         4263     4263           
  Misses        181      181           
  Partials      122      122           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash merged commit 7504d71 into master Mar 1, 2023
@shacharPash shacharPash deleted the fix-readme branch March 1, 2023 15:50
@shacharPash shacharPash added documentation Improvements or additions to documentation maintenance labels Mar 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants