Use setpriv instead of gosu for dropping privileges in the entrypoint #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter-Sh
force-pushed
the
RED-131427_setpriv_insteadof_gosu
branch
3 times, most recently
from
f4f7bdf to
9d21650
Compare
Changes: setpriv is used instead of gosu with the following flags: * Set reuid and regid to redis user and group * Clear all supplementary groups * Set bouding capabilities to an empty list * Enable no-new-privs bit * Set securebit to exclude regaining capabilities redis-sentinel is now also run with dropped privileges (previously, it wasn't) Both redis-sentinel and redis-server will start with dropped privileges, regardless of how they were started (whether using absolute paths or just file names)
redis-server may use sys_resource to increase open files limit if maxclients option has been requested
Peter-Sh
force-pushed
the
RED-131427_setpriv_insteadof_gosu
branch
from
9d21650 to
f7606b5
Compare
adobrzhansky
approved these changes
Mar 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kinda closes
#390
#401
#424
for Redis 8 CE.
Changes:
setprivis used instead ofgosuwith the following flags:Other changes:
redis-sentinelis now also run with dropped privileges (previously, it wasn't)redis-sentinelandredis-serverwill start with dropped privileges, regardless of how they were started (whether using absolute paths or just file names)