Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support garbage collection in Reader #162

Closed
oranav opened this issue Apr 4, 2023 · 1 comment
Closed

Support garbage collection in Reader #162

oranav opened this issue Apr 4, 2023 · 1 comment

Comments

@oranav
Copy link
Contributor

oranav commented Apr 4, 2023

Reader object may hold references to non-primitive objects, such as through replyError; therefore, it must support garbage collection, which it does not right now.

This may lead to memory leaks, such as happened in redis/redis-py#2693.
oranav added a commit to oranav/hiredis-py that referenced this issue Apr 4, 2023
@oranav
Implement garbage collection support in Reader (redis#162)
960aeef
@oranav oranav mentioned this issue Apr 4, 2023
Merged
oranav added a commit to oranav/hiredis-py that referenced this issue Apr 4, 2023
@oranav
Implement garbage collection support in Reader (redis#162)
bd45034
chayim pushed a commit that referenced this issue May 4, 2023
@oranav
Implement garbage collection support in Reader (#162) (#163)
01add3c
@chayim
Copy link
Contributor

chayim commented May 4, 2023

Closed by the merge of #162.

@chayim chayim closed this as completed May 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oranav @chayim