Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add SslOptions #3980

Merged
merged 50 commits into from
Jan 6, 2025
Merged

Add SslOptions #3980

merged 50 commits into from
Jan 6, 2025

Conversation

sazzad16
Copy link
Collaborator

Similar to SslOptions in Lettuce library.

Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

@tishun
Copy link

tishun commented Oct 1, 2024

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

I have the same question. The motivation of the change is important in this case.

@uglide
Copy link
Contributor

uglide commented Oct 2, 2024

@tishun @atakavci This is an attempt to create a TLS config similar to what we have in Lettuce, as a more developer-friendly option compared to the current approach with SSLSocketFactory, etc.

@sazzad16
Copy link
Collaborator Author

sazzad16 commented Oct 2, 2024

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

I have the same question. The motivation of the change is important in this case.

@tishun

  1. Lettuce has similar support.
  2. Users want insecurity.

Copy link

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not be getting the whole idea, so please excuse me if my comments are not making sense.

My current assumption is that we only want to be able to enable and disable hostname verification, as part of the SSL verification process.

src/main/java/redis/clients/jedis/SslOptions.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/SslOptions.java Outdated Show resolved Hide resolved
@sazzad16 sazzad16 marked this pull request as ready for review December 17, 2024 17:49
@sazzad16 sazzad16 requested review from a team, ggivo, atakavci, tishun and uglide December 17, 2024 18:47
tishun
tishun previously approved these changes Dec 18, 2024
Copy link

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

tishun
tishun previously approved these changes Dec 19, 2024
@sazzad16 sazzad16 merged commit 87d451c into redis:master Jan 6, 2025
5 checks passed
@sazzad16 sazzad16 deleted the ssl-options branch January 6, 2025 13:27
@sazzad16 sazzad16 added this to the 5.3.0 milestone Jan 6, 2025
ggivo added a commit to ggivo/jedis that referenced this pull request Jan 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants