Skip to content

Add support for CLIENT NO-TOUCH #2497

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

codrin-ch
Copy link
Contributor

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Fix for #2455

@leibale
Copy link
Contributor

leibale commented May 3, 2023

@codrin-ch thanks for contributing! We are actively working on v5, which changes the way commands are defined a bit (see PING in the v5 branch for example). If you can convert this PR to be for v5 it'll be awesome :)

@codrin-ch
Copy link
Contributor Author

codrin-ch commented May 3, 2023

@leibale if there is no urgency for 7.2 new functionalities support maybe it would be better to avoid combining migration to v5 with new functionalities and prepare a separate branch for 7.2 support with all the requirements and release it after v5 reaches master and the version is validated and stable?

@leibale
Copy link
Contributor

leibale commented May 3, 2023

@codrin-ch the 7.2 commands are in the v5 backlog anyway.. :)

@leibale leibale changed the title Add support for new redis command CLIENT NO-TOUCH Add support for CLIENT NO-TOUCH Sep 18, 2023
@leibale leibale merged commit 4e610c2 into redis:master Sep 18, 2023
@leibale
Copy link
Contributor

leibale commented Sep 19, 2023

@codrin-ch redis@4.6.9/@redis/client@1.5.10 is on npm 🎉

florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants