Skip to content

Send client user-agent during connection, via CLIENT SETINFO #2645

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2023
Merged

Send client user-agent during connection, via CLIENT SETINFO #2645

merged 3 commits into from
Nov 7, 2023

Conversation

sjpotter
Copy link
Contributor

@sjpotter sjpotter commented Nov 2, 2023 •
edited by chayim
Loading

Description

Describe your pull request here

client is able to provide it's "user agent" to redis server.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

closes #2573
closes #2612
closes #2456

@sjpotter sjpotter requested a review from chayim November 2, 2023 15:33
chayim
chayim reviewed Nov 7, 2023
View reviewed changes
@chayim chayim changed the title Add SETINFO support to client connection Send client user-agent during connection, via CLIENT SETINFO Nov 7, 2023
@chayim chayim added the feature label Nov 7, 2023
@sjpotter sjpotter merged commit a8b81bd into redis:master Nov 7, 2023
@leibale
Copy link
Contributor

leibale commented Jan 16, 2024

@sjpotter please add the new options to the options table here

@garyburgmann garyburgmann mentioned this pull request May 9, 2025
Closed
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
@sjpotter
Send client user-agent during connection, via CLIENT SETINFO (redis#2645
4e1eaf4 
)

* Add SETINFO support to client connection, with the ability to disable sending the user agent if the end user desires.  * Also enables modifying the user-agent with a tag to enable distinguishing different usages.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CLIENT-SETINFO to support suffixes Clients should identify themselves on connect Add support for new redis command CLIENT SETINFO
3 participants
@sjpotter @leibale @chayim