fix(ts): xtrim threshold accepts string #2828
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis#2783) * shallow copy of this.#options.defaults.socket * shallow copy of this.#options.defaults.socket * nit --------- Co-authored-by: Max Gruenfelder <maximilian.gruenfelder@sap.com> Co-authored-by: Leibale Eidelman <me@leibale.com>
copied from what leibele did for v5
* Support the NOVALUES option of HSCAN Issue redis#2705 The NOVALUES option instructs HSCAN to only return keys, without their values. This is materialized as a new command, `hScanNoValues`, given that the return type is different from the usual return type of `hScan`. Also a new iterator is provided, `hScanNoValuesIterator`, for the same reason. * skip hscan novalues test if redis < 7.4 * Also don't test hscan no values iterator < 7.4 --------- Co-authored-by: Shaya Potter <spotter@gmail.com>
* add addscores to aggregate search command * change `true` to `boolean` --------- Co-authored-by: Leibale Eidelman <me@leibale.com>
* add 7.4-rc2 to github action test suite * Update tests.yml --------- Co-authored-by: Leibale Eidelman <me@leibale.com>
* fix: json.mget should be readonly (redis#2807) * lint
* small refactor per discussion with leibele * move true type to boolean type * fix geoshape to support NOINDEX & SORTABLE, clean code * fix for last commit --------- Co-authored-by: Leibale Eidelman <me@leibale.com>
|
Good catch! Can you please do it for the v5 branch instead? Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
XTRIMcommand accepts a streamId that is a string:Checklist
npm testpass with this change (including linting)?