Skip to content

[CAE-827] Changed ft create vector types to union, added support for int8/uint8 #2911

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

htemelski
Copy link

@htemelski htemelski commented Mar 21, 2025

Description

Changed the vector type field from string to union with all supported versions (including int8 and uint8)


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@htemelski htemelski requested a review from bobymicroby March 21, 2025 08:28
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@htemelski htemelski merged commit d64072d into master Mar 21, 2025
11 checks passed
@htemelski htemelski deleted the cae-827 branch March 21, 2025 09:43
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
…on, added support for int8/uint8 (redis#2911)

* [CAE-827] Changed ft create vector types to union, added support for int8/uint8

* [CAE-827] Moved test cases
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants