Skip to content

fix: fix various command import issues #2944

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

nkaradzhov
Copy link
Collaborator

there was some sort of a circular dependency
in /lib/commands/index.ts for various modules

fixes #2937 fixes #2941

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

there was some sort of a circular dependency
in <module>/lib/commands/index.ts for various modules

fixes redis#2937 fixes redis#2941
@nkaradzhov nkaradzhov merged commit 7b73782 into redis:master May 7, 2025
11 checks passed
@nkaradzhov nkaradzhov deleted the fix-helper-functions branch May 7, 2025 13:10
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
* fix: fix various command import issues

there was some sort of a circular dependency
in <module>/lib/commands/index.ts for various modules

fixes redis#2937 fixes redis#2941

* remove redundant definition
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrating from v4 to v5 causes error for reading JSON json.get sometimes returning a string instead of json
2 participants