Skip to content

fix(cluster): replace native private with _ #2971

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix(cluster): replace native private with _ #2971

merged 1 commit into from
May 22, 2025

Conversation

nkaradzhov
Copy link
Collaborator

Private class fields (e.g., #execute) cause runtime errors when accessed from contexts where this is not the exact instance, triggering “Receiver must be an instance of class RedisCluster”.

fixes #2967

Description

Describe your pull request here

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@nkaradzhov
fix(cluster): replace native private with _
861ec9d 
Private class fields (e.g., #execute) cause runtime errors when accessed from contexts where `this` is not the exact instance, triggering “Receiver must be an instance of class RedisCluster”.

fixes redis#2967
bobymicroby
bobymicroby approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkaradzhov nkaradzhov merged commit 27537b0 into redis:master May 22, 2025
11 checks passed
@nkaradzhov nkaradzhov deleted the module-commands-broken-in-cluster branch May 22, 2025 07:35
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
@nkaradzhov
fix(cluster): replace native private with _ (redis#2971)
a091590 
Private class fields (e.g., #execute) cause runtime errors when accessed from contexts where `this` is not the exact instance, triggering “Receiver must be an instance of class RedisCluster”.

fixes redis#2967
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

@htemelski htemelski Awaiting requested review from htemelski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receiver must be an instance of class RedisCluster
2 participants
@nkaradzhov @bobymicroby