Skip to content

Main #3047

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Main #3047

wants to merge 1 commit into from

Conversation

watersRand
Copy link

#corrected issues raised by maintainer
#rolled back latency histogram

Copy link
Collaborator

@nkaradzhov nkaradzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the package-lock.json from the PR

@watersRand
Copy link
Author

Done! The package-lock.json file has been removed.

@nkaradzhov
Copy link
Collaborator

Hi @watersRand, i can still see the package-lock.json being in the diff. Did you add it again?

@watersRand
Copy link
Author

Please @nkaradzhov guide me on the issue .I have both removed and added the package-json yet still issues were raised

@nkaradzhov
Copy link
Collaborator

@watersRand the package-lock.json file should not be part of the PR.

I asked you to remove it. You removed it, and then introduced it again.

image

I dont know how better to articulate this.

@watersRand
Copy link
Author

removed the package-lock.json

@nkaradzhov
Copy link
Collaborator

@watersRand it looks like the package-lock.json is still in the diff of the PR:
image

Just to say it again, your PR changes should consist of only the index.ts, LATENCY_RESET.ts and LATENCY_RESET.spec.ts. If it is easier for you, I can suggest to copy the contents of those 3 files, then hard-reset your master branch to node-redis/master and then paste your files and make the commit. Your commit should not have anything besides the 3 files index.ts, LATENCY_RESET.ts and LATENCY_RESET.spec.ts.

@nkaradzhov nkaradzhov requested a review from PavelPashov August 21, 2025 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants