Skip to content

Removing Spring AI BOM #541

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

raphaeldelio
Copy link
Contributor

I ran another test:

  1. Remove Spring AI BOM folder from .m2:
    rm -rf ~/.m2/repository/org/springframework/ai/spring-ai-bom

  2. Reload Maven project:
    2.1. with Redis OM Spring v0.9.8:
    Directory and contents are recreated

2.2. with a new snapshot of Redis OM Spring without Spring AI BOM:
Directory and contents are not recreated.

Turns out that even though Maven won't download the actual dependencies (and that's why nothing shows in the dependency tree), it will still import the POM file of the BOM. To avoid this from happening, I simply removed the BOM and managed the versions of Spring AI optional dependencies manually.

Copy link
Collaborator

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsbodden bsbodden merged commit 0cb7052 into redis:main Feb 10, 2025
4 checks passed
@raphaeldelio raphaeldelio deleted the feature/by-passing-spring-ai-bom branch April 30, 2025 10:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants