Skip to content

Support MINID and LIMIT on XADD #1548

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Aug 29, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Aug 19, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@AvitalFineRedis AvitalFineRedis changed the title MINID and LIMIT Support MINID and LIMIT on XADD Aug 19, 2021
@AvitalFineRedis
Copy link
Contributor Author

#1546

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inlines. Thanks @AvitalFineRedis

@AvitalFineRedis AvitalFineRedis requested a review from chayim August 29, 2021 06:40
@chayim chayim merged commit 295b547 into redis:master Aug 29, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
Support MINID and LIMIT on XADD (redis/redis-py#1548)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants