Skip to content

Support WRITE in CLIENT PAUSE #1549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 16 commits into from
Dec 22, 2021
Merged

Conversation

AvitalFineRedis
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

support WRITE on CLIENT PAUSE

@AvitalFineRedis AvitalFineRedis marked this pull request as draft August 22, 2021 08:09
@AvitalFineRedis AvitalFineRedis changed the title general support ALL in CLIENT PAUSE Aug 23, 2021
@AvitalFineRedis AvitalFineRedis changed the title support ALL in CLIENT PAUSE support WRITE in CLIENT PAUSE Aug 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1549 (e30971b) into master (e0d3ba5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
+ Coverage   94.31%   94.32%   +0.01%     
==========================================
  Files          75       75              
  Lines       15835    15843       +8     
==========================================
+ Hits        14934    14944      +10     
+ Misses        901      899       -2     
Impacted Files Coverage Δ
tests/test_json.py 100.00% <ø> (ø)
redis/commands/core.py 90.11% <100.00%> (+0.02%) ⬆️
tests/test_commands.py 99.38% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 98.67% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d3ba5...e30971b. Read the comment docs.

@chayim chayim added 4.1.0 and removed 4.0.+ labels Nov 29, 2021
@chayim chayim marked this pull request as ready for review December 22, 2021 08:37
@chayim chayim self-requested a review December 22, 2021 08:37
@chayim chayim changed the title support WRITE in CLIENT PAUSE Support WRITE in CLIENT PAUSE Dec 22, 2021
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chayim chayim merged commit f99744b into redis:master Dec 22, 2021
@AvitalFineRedis AvitalFineRedis deleted the CLIENT_PAUSE-WRITE branch December 23, 2021 07:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants