Skip to content

Adding ROLE Command #1610

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 13 commits into from
Dec 2, 2021
Merged

Adding ROLE Command #1610

merged 13 commits into from
Dec 2, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Oct 14, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@AvitalFineRedis AvitalFineRedis changed the title implement ROLE Support ROLE Oct 14, 2021
@AvitalFineRedis
Copy link
Contributor Author

@chayim, I'm not sure if I need to test more than that...

@chayim chayim added 4.0.+ feature New feature labels Nov 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1610 (d1ae2eb) into master (d4a9825) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.02%     
==========================================
  Files          74       74              
  Lines       15617    15628      +11     
==========================================
+ Hits        14369    14377       +8     
- Misses       1248     1251       +3     
Impacted Files Coverage Δ
tests/test_connection_pool.py 94.54% <ø> (ø)
redis/commands/core.py 84.74% <83.33%> (-0.02%) ⬇️
tests/test_commands.py 93.45% <100.00%> (+0.01%) ⬆️
tests/test_cluster.py 97.24% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a9825...d1ae2eb. Read the comment docs.

@chayim chayim added 4.1.0 and removed 4.0.+ labels Nov 29, 2021
@chayim chayim changed the title Support ROLE Adding ROLE Command Nov 30, 2021
@chayim chayim merged commit c2d4621 into redis:master Dec 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants