Skip to content

Adding support for non-decodable commands #1731

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 21, 2021

Some commands (i.e DUMP) should never have their response decoded, as they return binaries, not encoded blobs

fixes #1254
closes #1732

Some commands (i.e DUMP) should never have their response decoded, as they return binaries, not encoded blobs

fixes #1254
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #1731 (1448a65) into master (d2b2333) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1731   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          53       53           
  Lines       11052    11058    +6     
=======================================
+ Hits         9841     9847    +6     
  Misses       1211     1211           
Impacted Files Coverage Δ
redis/connection.py 71.11% <66.66%> (ø)
redis/client.py 82.15% <100.00%> (+0.06%) ⬆️
redis/commands/core.py 83.91% <100.00%> (+0.03%) ⬆️
redis/sentinel.py 86.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b2333...1448a65. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle response encoding and decoding running dump() fails when decode_responses=True
2 participants