Skip to content

Add BITFIELD_RO #2340

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Add BITFIELD_RO #2340

merged 1 commit into from
Aug 21, 2022

Conversation

bodevone
Copy link
Contributor

@bodevone bodevone commented Aug 16, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add BITFIELD_RO

Closes #1966

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #2340 (3d5884d) into master (771109e) will decrease coverage by 13.62%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2340       +/-   ##
===========================================
- Coverage   92.19%   78.56%   -13.63%     
===========================================
  Files         111      111               
  Lines       28751    28776       +25     
===========================================
- Hits        26507    22609     -3898     
- Misses       2244     6167     +3923     
Impacted Files Coverage Δ
redis/commands/core.py 82.00% <100.00%> (-0.11%) ⬇️
tests/test_asyncio/test_commands.py 98.39% <100.00%> (+<0.01%) ⬆️
tests/test_commands.py 89.71% <100.00%> (-0.10%) ⬇️
tests/test_cluster.py 18.58% <0.00%> (-78.50%) ⬇️
tests/test_asyncio/test_cluster.py 18.88% <0.00%> (-78.40%) ⬇️
redis/asyncio/cluster.py 16.52% <0.00%> (-73.77%) ⬇️
redis/cluster.py 18.81% <0.00%> (-71.04%) ⬇️
redis/asyncio/parser.py 17.30% <0.00%> (-63.47%) ⬇️
redis/commands/cluster.py 37.57% <0.00%> (-56.07%) ⬇️
redis/crc.py 45.45% <0.00%> (-54.55%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -2953,6 +2953,19 @@ async def test_bitfield_operations(self, r: redis.Redis):
)
assert resp == [0, None, 255]

@skip_if_server_version_lt("6.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize the documentation is confusing here. But it appears the command is available since 6.0.0, but the help text indicates it's from Redis 6.2

@itamarhaber can you weigh in on which is correct, so that we get this tagged appropriately?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BITFIELD_RO was added in Redis v6.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks! Seems like a doc needs changing in redis-docs In that case, stamped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the error in the docs
image

@bodevone bodevone requested a review from chayim August 19, 2022 05:59
@chayim chayim added the feature New feature label Aug 21, 2022
@dvora-h dvora-h merged commit 031b208 into redis:master Aug 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for missing command BITFIELD_RO
5 participants