-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add BITFIELD_RO #2340
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add BITFIELD_RO #2340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
===========================================
- Coverage 92.19% 78.56% -13.63%
===========================================
Files 111 111
Lines 28751 28776 +25
===========================================
- Hits 26507 22609 -3898
- Misses 2244 6167 +3923
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -2953,6 +2953,19 @@ async def test_bitfield_operations(self, r: redis.Redis): | |||
) | |||
assert resp == [0, None, 255] | |||
|
|||
@skip_if_server_version_lt("6.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize the documentation is confusing here. But it appears the command is available since 6.0.0, but the help text indicates it's from Redis 6.2
@itamarhaber can you weigh in on which is correct, so that we get this tagged appropriately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BITFIELD_RO
was added in Redis v6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks! Seems like a doc needs changing in redis-docs In that case, stamped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Add BITFIELD_RO
Closes #1966