Skip to content

Fix for Unhandled exception related to self.host with unix socket #2520

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Dec 25, 2022

Conversation

winmorre
Copy link
Contributor

@winmorre winmorre commented Dec 18, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added a fix for Issue #2496 .
Included a try/except block to catch this error and set a default "connection" for the instance when host is not provided

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 92.22% // Head: 92.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b40f7a9) compared to base (f06f3db).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2520   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         113      113           
  Lines       29375    29380    +5     
=======================================
+ Hits        27092    27097    +5     
  Misses       2283     2283           
Impacted Files Coverage Δ
redis/connection.py 86.60% <76.92%> (+0.08%) ⬆️
tests/test_cluster.py 96.90% <0.00%> (-0.12%) ⬇️
tests/test_asyncio/test_cluster.py 97.60% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h added the bug Bug label Dec 19, 2022
@dvora-h dvora-h merged commit 55298e4 into redis:master Dec 25, 2022
@winmorre winmorre deleted the bug-fix/#2496 branch December 31, 2022 19:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants