Fix resource usage and cleanup Mocks in the unit tests #2936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
In pr #2911, we uncovered some problems in the unittests.
test_cwe_404.py
.asyncio.wait()
must not wait for coroutines directly (this will be banned in 3.11) but must use tasks.spec
arguments and so methods, which weren't async, caused resource warnings. Mocking should use spec when possible.Redis
objects when simulating a cluster in nocluster mode was not done and so the test suite would attempt to return mock objects to a connection pool that had never issued them.In addition, a fix to a permanently disabled Unix connection test is included.