Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make message in LockError optional to support backwards compatibility #3176

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Mar 6, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from a team March 6, 2024 09:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (2f88840) to head (75a7bf3).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3176      +/-   ##
==========================================
+ Coverage   91.84%   91.86%   +0.01%     
==========================================
  Files         128      128              
  Lines       33232    33322      +90     
==========================================
+ Hits        30523    30612      +89     
- Misses       2709     2710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h added the bug Bug label Mar 7, 2024
@dvora-h dvora-h merged commit 9ad1546 into redis:master Mar 7, 2024
47 checks passed
dvora-h added a commit that referenced this pull request Mar 10, 2024
dvora-h added a commit that referenced this pull request Mar 10, 2024
* Fix lock error (#3176)

* Remove redundant async-timeout dependency in modern Python (#3177)

#3174

* Bump rojopolis/spellcheck-github-actions from 0.35.0 to 0.36.0 (#3172)

Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.35.0 to 0.36.0.
- [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
- [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
- [Commits](rojopolis/spellcheck-github-actions@0.35.0...0.36.0)

---
updated-dependencies:
- dependency-name: rojopolis/spellcheck-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump release-drafter/release-drafter from 5 to 6 (#3171)

Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5 to 6.
- [Release notes](https://github.com/release-drafter/release-drafter/releases)
- [Commits](release-drafter/release-drafter@v5...v6)

---
updated-dependencies:
- dependency-name: release-drafter/release-drafter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kamil Monicz <kamil@monicz.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants