Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make it possible to return raw fields in search results #3256

Closed

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented May 29, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

In some use cases (e.g. vector search), the fields in the search results must not be decoded. Add an optional parameter to the search methods, which makes it possible to disable decoding.

In order to not break the existing functionality, the parameter has the default value set to True, i.e. it will decode like before.

Fixes #2772

In some use cases (e.g. vector search), the fields in the search results
must not be decoded. Add an optional parameter to the search methods,
which makes it possible to disable decoding.

In order to not break the existing functionality, the parameter has the
default value set to True, i.e. it will decode like before.
@gerzse gerzse added the bug Bug label May 29, 2024
@gerzse gerzse requested review from uglide and vladvildanov May 29, 2024 16:05
@bsbodden
Copy link

@gerzse I would reference the original bug report in the PR #2772

Otherwise it looks good to me! Other than run the linters locally to appease the formatting gods!

@gerzse gerzse marked this pull request as draft July 3, 2024 09:06
@gerzse
Copy link
Contributor Author

gerzse commented Jul 11, 2024

This is superseded by #3309

@gerzse gerzse closed this Jul 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants