Skip to content

Fix parsing of the is_master attribute in the URL #3367

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JackiLin
Copy link

@JackiLin JackiLin commented Sep 4, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixed the parsing of the is_master attribute in the Redis URL.
When the Redis URL is 'redis://redis-master/1?is_master=0', it is supposed to find the slave node of redis-master for read operations. However, since is_master was parsed as '0' and not correctly interpreted as False, it failed to use the slave node.
I encountered this issue when trying to implement read-write separation using SentinelConnectionPool.

@JackiLin JackiLin marked this pull request as draft September 4, 2024 06:35
@JackiLin JackiLin marked this pull request as ready for review September 6, 2024 08:04
@vladvildanov vladvildanov added the techdebt Things that can be improved or refactored label Sep 19, 2024
@vladvildanov
Copy link
Collaborator

@JackiLin Thanks for you contribution! I would ask you to provide a test case

@JackiLin
Copy link
Author

@JackiLin Thanks for you contribution! I would ask you to provide a test case

Is it OK to add test cases like this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
techdebt Things that can be improved or refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants