Skip to content

Removing unnecessary check #3432

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IlianIliev
Copy link
Contributor

@IlianIliev IlianIliev commented Nov 13, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

With Python 3.8 being the minimal version, there is no longer a need to check if mock.AsyncMock is available.

@IlianIliev IlianIliev force-pushed the removing-unnecessary-check branch 3 times, most recently from fd39178 to adaa3a2 Compare November 13, 2024 20:12
@IlianIliev IlianIliev marked this pull request as ready for review November 13, 2024 21:14
@IlianIliev IlianIliev force-pushed the removing-unnecessary-check branch 2 times, most recently from 553cee1 to da3299d Compare December 19, 2024 21:48
@IlianIliev IlianIliev force-pushed the removing-unnecessary-check branch from da3299d to a8f4f63 Compare December 20, 2024 07:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants