Skip to content

Allow multi-node commands in async pipeline #3439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Yard1
Copy link
Contributor

@Yard1 Yard1 commented Nov 19, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

While RedisCluster.execute_command supports multi-node commands (and returns a dictionary of {node.name: result}), ClusterPipeline did not allow for it. This PR adds support for multi-node commands in ClusterPipeline. The results of those commands will be put into the returned list in format consistent with RedisCluster.execute_command.

@Yard1 Yard1 force-pushed the yard1/multinode-commands-pipeline branch from f9cd998 to cf1875d Compare December 17, 2024 17:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant