Improve CI test runtime with pytest-xdist #270
+652
−675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some issue with the latest redis stack version??? |
abrookins
reviewed
Feb 6, 2025
scripts.py
Outdated
|
|
||
|
|
||
| def test_verbose(): | ||
| subprocess.run( | ||
| ["python", "-m", "pytest", "-vv", "-s", "--log-level=CRITICAL"], check=True | ||
| ["python", "-m", "pytest", "-n", "6", "-vv", "-s", "--log-level=CRITICAL"], check=True |
There was a problem hiding this comment.
I'd use "auto" here. As a data point, if I use "auto" and set Docker's resources to use all cores, pytest assigns 14 cores and I see a ~16s speedup locally (76.39s with 6 cores, 61.40s with "auto"/14 cores).
abrookins
reviewed
Feb 6, 2025
abrookins
approved these changes
Feb 6, 2025
| compose.start() | ||
|
|
||
| # If you mapped the container port 6379:6379 in docker-compose.yml, | ||
| # you might have collisions across workers. If you rely on ephemeral | ||
| # host ports, remove the `ports:` block in docker-compose.yml and do: | ||
| redis_host, redis_port = compose.get_service_host_and_port("redis", 6379) |
There was a problem hiding this comment.
Suggested change
| redis_host, redis_port = compose.get_service_host_and_port("redis", 6379) | |
| #redis_host, redis_port = compose.get_service_host_and_port("redis", 6379) |
| redis_host, redis_port = compose.get_service_host_and_port("redis", 6379) | ||
| redis_url = f"redis://{redis_host}:{redis_port}" | ||
| os.environ["REDIS_URL"] = redis_url |
There was a problem hiding this comment.
Should line 35 also be commented out? (I added a suggestion for it.)
This isn't a blocker for me, but ideally, the codebase should only support and suggest behavior that's configurable at runtime through environment variables or CLI flags, without requiring developers to comment or uncomment code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-xdistruns workers to tackle the test suite concurrently (using more cpus):https://pytest-xdist.readthedocs.io/en/stable/distribution.html#running-tests-across-multiple-cpus
The addition of this tool AND some small updates to testcontainer usage (for Redis instances) helps us achieve a ~3-4x speed up locally.