Route reference methods #322
Open
+728
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+161
to
+179
| @staticmethod | ||
| def _connect_to_index( | ||
| router_name: str, | ||
| vectorizer: BaseVectorizer, | ||
| redis_client: Optional[Redis] = None, | ||
| redis_url: str = "redis://localhost:6379", | ||
| **connection_kwargs, | ||
| ) -> SearchIndex: | ||
| """Connect to the Redis index.""" | ||
| schema = SemanticRouterIndexSchema.from_params( | ||
| router_name, vectorizer.dims, vectorizer.dtype # type: ignore | ||
| ) | ||
|
|
||
| return SearchIndex( | ||
| schema=schema, | ||
| redis_client=redis_client, | ||
| redis_url=redis_url, | ||
| **connection_kwargs, | ||
| ) |
There was a problem hiding this comment.
Why do we need to pull this out as a separate method when we only execute this code within _initialize_index()?
| redis_client: Optional[Redis] = None, | ||
| redis_url: str = "", | ||
| ) -> int: | ||
| """Get references for an existing route route. |
There was a problem hiding this comment.
Suggested change
| """Get references for an existing route route. | |
| """Get references for an existing router route. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add methods so that you can easily get/add/delete route references.