Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: improve module interfacing #25

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

redmer
Copy link
Owner

@redmer redmer commented Oct 31, 2023

This PR refactors

  1. the data meta-model module interface
  2. the default Facade-X data meta-model according to this interface
  3. the GeoSPARQL output to be according to this interface

(1) prepares for future modules by enabling more encapsulation of a module class.

(2) improves the locality of the Facade-X output.
That in turn makes it easier to make new modules based off the Facade-X module.

(3) makes clearer how geometries are generated, when they're reprojected and how they're output.

@redmer redmer merged commit f12c143 into main Oct 31, 2023
@redmer redmer deleted the refactor-default-models branch October 31, 2023 09:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant