Replace redpencilio and remove -service #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces redpencilio to redpencil but leaves other repo namespaces in tact. - removes -service from the repository name as this normally exists on GitHub but not on Docker Hub (on all builds).
Github has redpencilio as org name, docker hub has redpencil. This automatically replaces and does not ruin other builds.
|
I like these as examples for how to modify the params with string operations, probably a good idea to update the readme as well. As you mentioned yourself (and a reminder so we don't forget), stripping service from a frontend doens't make a lot of sense. On stripping service, it looks like that's not a practice we follow on LBLOD. It can still be part of the template if we want that to be the default though. |
A frontend will not have a redundant -service postfix in its name. A suggestion to remove this adds complexity and raises the chance for errors.
The templates have been altered. Updating the README so it's more obvious what is going on.
|
@madnificent apologies, this never got merged an we've since moved our preference to woodpecker. I'll leave it up to you whether you want to rebase your PR or close it. |
|
Can someone else pick this up? Should be applied to woodpecker too. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces redpencilio to redpencil but leaves other repo namespaces in
tact.
removes -service from the repository name as this normally exists on
GitHub but not on Docker Hub (on all builds).
Next steps
Also update the build for the frontend.