Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RS-510: Rename entry with web console #71

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

AnthonyCvn
Copy link
Contributor

@AnthonyCvn AnthonyCvn commented Nov 5, 2024

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

feature

What was changed?

As a user, I can rename entry with Web Console

Related issues

No

Does this PR introduce a breaking change?

Version 1.12: The rename method was introduced.

Other information:

@AnthonyCvn AnthonyCvn requested a review from atimin November 5, 2024 11:08
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect. Just add a check for the method call in the test.

@AnthonyCvn AnthonyCvn requested a review from atimin November 5, 2024 16:51
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@atimin atimin merged commit 86ed0ca into main Nov 5, 2024
5 checks passed
@atimin atimin deleted the RS-510-As-a-user-I-can-rename-entry-with-Web-Console branch November 5, 2024 16:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants