Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RS-594: Filter data in object explorer with when conditions #80

Merged

Conversation

AnthonyCvn
Copy link
Contributor

@AnthonyCvn AnthonyCvn commented Feb 22, 2025

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What was changed?

Filter data with when conditions in object explorer with JSON editor

Related issues

No

Does this PR introduce a breaking change?

No

Other information:

@AnthonyCvn AnthonyCvn requested a review from atimin February 22, 2025 16:50
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good. However, it doesn't work properly for request with the same label name. Check please with this conditions:

{
  "&left-ear-1-x": {
    "$lt": 150
  },
  "&left-ear-1-x": {
    "$gt": 250
  }
  
}

It also doesn't show error message if I use wrong operator:

{
  "&left-ear-1-x": {
    "$gyt": 250
  }
}

@AnthonyCvn
Copy link
Contributor Author

@atimin I'm stuck parsing duplicate keys from JSON. Do you have any idea how to do this correctly?

@atimin
Copy link
Member

atimin commented Feb 25, 2025

{
  "&left-ear-1-x": {
    "$lt": 150
  },
  "&left-ear-1-x": {
    "$gt": 250
  }
  
}

it is not a bug , it is how a dictionary works with the key duplication.

@atimin atimin self-requested a review February 25, 2025 09:37
@AnthonyCvn AnthonyCvn merged commit 02eceb2 into main Feb 25, 2025
5 checks passed
@AnthonyCvn AnthonyCvn deleted the RS-594-Filter-data-in-object-explorer-with-when-conditions branch February 25, 2025 09:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants