Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Throwing an error when no modelName is set in register #231

Conversation

Chris-Congenica
Copy link
Contributor

Based on the comments in #197 I've added the check in register. I've also added a test to assert that when the modelName isn't set an error is thrown.

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you propose PR to correct branch: hotfix for master, feature for latest active branch feature/x.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Adding tests to expect an error to be thrown
@haveyaseen haveyaseen merged commit b859194 into redux-orm:master Sep 27, 2018
@haveyaseen haveyaseen added type: Enhancement This intends to enhance the project. layer: Model labels May 7, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
layer: Model type: Enhancement This intends to enhance the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants