Skip to content

IE10 does not support Map (#325) #326

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

xfields
Copy link
Contributor

@xfields xfields commented Sep 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          27       27           
  Lines         132      132           
  Branches       39       40    +1     
=======================================
  Hits          127      127           
  Misses          4        4           
  Partials        1        1
Impacted Files Coverage Δ
src/utils/isMap.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51de389...9a5d7a4. Read the comment docs.

@heygrady
Copy link
Contributor

heygrady commented Oct 16, 2018

You should use a polyfill in your project. A typical react app needs some polyfills.

Try adding this to the top of your entry point:

// @see https://reactjs.org/docs/javascript-environment-requirements.html
import 'raf/polyfill'
import 'core-js/modules/es6.map'
import 'core-js/modules/es6.set'

This PR should probably be about updating the README to let people know they need to supply polyfills for Map.

@xfields
Copy link
Contributor Author

xfields commented Nov 1, 2018

My project got en error (#325) on IE10 after I update redux-actions to 2.6.1.

I don't think it is a good idea to add a polyfill by whom use redux-actions, they may just don't need the Map class.

@heygrady
Copy link
Contributor

heygrady commented Nov 1, 2018

Oh, I see. In this case Map isn’t used except as a type check. Your fix actually looks correct.

@timche timche merged commit 2998518 into redux-utilities:master Nov 1, 2018
@timche
Copy link
Member

timche commented Nov 1, 2018

Thanks 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants