Skip to content

IE11 does not support String.prototype.includes #335

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

verebelyin
Copy link
Contributor

@verebelyin verebelyin commented Nov 22, 2018

#306 broke IE11 due to it's not supporting String.prototype.includes

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          28       28           
  Lines         130      130           
  Branches       39       39           
=======================================
  Hits          126      126           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/utils/camelCase.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6daa0c0...c48ace0. Read the comment docs.

@ricale
Copy link

ricale commented Feb 15, 2019

It's wrong title. No Array.prototype.includes in this case. String.prototype.includes is right.

@verebelyin verebelyin changed the title IE11 does not support Array.prototype.includes IE11 does not support String.prototype.includes Feb 15, 2019
@timche
Copy link
Member

timche commented Feb 18, 2019

Sorry for the long waiting. Thanks for fixing this 👍

@timche timche merged commit 448fa42 into redux-utilities:master Feb 18, 2019
@vinnymac
Copy link
Contributor

vinnymac commented Mar 4, 2019

@timche anything I can do to get a v2.6.5 with this in it? Discovered this issue broke IE11 for one of my clients today and I don't want to rollback to v2.6.3 and break things for IE10 users.

@timche
Copy link
Member

timche commented Mar 4, 2019

@vinnymac I'm sorry letting you wait. I've published v2.6.5.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants