Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lower react peer dependency to ^16.8.3 #1242

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Lower react peer dependency to ^16.8.3 #1242

merged 1 commit into from
Apr 17, 2019

Conversation

jeremy-deutsch
Copy link
Contributor

This PR lowers the react peer dependency from ^16.8.4 to ^16.8.3. This is useful for React Native users, since the react peer dependency in react-native is exactly 16.8.3.

This should have no effect on existing v7 users, but does open up new users to DevTools potentially crashing if they aren't on react@^16.8.4.

@netlify
Copy link

netlify bot commented Apr 17, 2019

Deploy preview for react-redux-docs ready!

Built with commit 1cd418f

https://deploy-preview-1242--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Apr 17, 2019

I guess I'm cool with this. Ideally, they would be on the latest 16.8 release, but React Native's gonna React Native 🤷‍♂️

@markerikson
Copy link
Contributor

Agreed.

@timdorr timdorr merged commit d4b54b5 into reduxjs:master Apr 17, 2019
@jeremy-deutsch
Copy link
Contributor Author

@sscotth I’m not sure the React sync will be part of 0.59.5 - I know they’re trying to avoid changing transitive dependencies in patch versions

@sscotth
Copy link

sscotth commented Apr 18, 2019

You are right, they didn't get it ready in time.

react-native-community/releases#113 (comment)

Waiting for FB team to answer. Meanwhile, decided to do 0.59.5 w/o React sync. We will release 0.59.6 once we know it's safe and okay to do the bump.

@jeremy-deutsch jeremy-deutsch deleted the react-16.8.3 branch April 18, 2019 23:50
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
This PR lowers the `react` peer dependency from `^16.8.4` to `^16.8.3`. This is useful for React Native users, since the `react` peer dependency in `react-native` is [exactly `16.8.3`.](https://github.com/facebook/react-native/blob/master/package.json#L86)

This should have no effect on existing v7 users, but does open up new users to DevTools potentially crashing if they aren't on `react@^16.8.4`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants