Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add first version of types for useSelector hook #1753

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

lindskogen
Copy link
Contributor

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 553aeb5:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Jul 5, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: 553aeb5

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e39814dc7c060008e01656

😎 Browse the preview: https://deploy-preview-1753--react-redux-docs.netlify.app

@markerikson
Copy link
Contributor

Hah, this is hilarious! At literally the same time you filed this PR, I sat down and started trying to convert useSelector to TS myself, and I just got it working :)

Our changes are almost identical, for obvious reasons, but your version looks a bit more rigorously defined than what I'd done, so I'm happy to go with this instead.

@markerikson markerikson merged commit b1d384b into reduxjs:typescript-port Jul 6, 2021
@lindskogen
Copy link
Contributor Author

Oh sorry, I will ping you next time I start working on something 😅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants