Skip to content

[WIP] Proof of concept of batching updates #293

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] Proof of concept of batching updates #293

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Feb 18, 2016

This is a proof of concept of batching updates in <Provider>.
I’m not sure we want to get this in, but it can serve as a starting point.

Solves #292.

Remaining issues:

  • Should this be opt-in?
  • We need to verify this works with RN correctly.
  • Currently it forces you to use react-dom if you don’t use react-native which is a bummer for other renderers.

@esamattis
Copy link
Contributor

We need to verify this works with RN correctly.

I can verify that. I ported the test to for the real React Native environment it passes without manual unstable_batchedUpdates when using this branch.

Currently it forces you to use react-dom if you don’t use react-native which is a bummer for other renderers.

I see this as a blocker. Doing it as an opt-in would solve it but what would it look like?

Maybe?

<Provider store={store} updateBatcher={ReactDOM.unstable_batchedUpdates}>
  <MyApp />
<Provier>

But I do feel that users shouldn't have to care about this at all. This is pretty much just an implementation detail. It should just work.

@timdorr
Copy link
Member

timdorr commented Aug 14, 2016

Superseded by #416

@timdorr timdorr closed this Aug 14, 2016
@timdorr timdorr deleted the batch branch October 5, 2016 00:35
aikoven pushed a commit to aikoven/react-redux that referenced this pull request Nov 21, 2016
neeharv pushed a commit to neeharv/react-redux that referenced this pull request Feb 18, 2017
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants